Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The motivation of this PR is to remove the client secret in the GitHub actions workflow file cicd.yml to improve security.
To do this, I reference this page and use the federated credentials in service principal which allows authentication without the need for explicit client secret and made corresponding changes to authentication in the workflow.
This PR introduces basically the same code changes as in this PR.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I created federated credential for this branch
user/elay/remove-client-secret
, so it can use the service principal to authenticate to Azure. It will be deleted after testing. In cicd.yml , changed branch trigger touser/elay/remove-client-secret
and comment out the if clause, so that
build_and_publish
anddeploy
jobs can all be tested once changes are pushed to this branch instead of main. Check out the result of latest pipeline run and workflow fileChecklist:
Please delete options that are not relevant.